Ticket #127 (enhancement)
Opened 3 years ago
Last modified 3 years ago
Stretched close button with cropped image
Status: closed (fixed)
| Reported by: | loopback | Assigned to: | chipx86 |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | notification-daemon | Version: | |
| Severity: | trivial | Keywords: | |
| Cc: | luca.cavalli@gmail.com | D-BUS Version: | |
| Patch Included: | 1 | OS/Distro Version: | |
With standard theme close button has cropped image and if the notification title is splitted on multiple lines it is stretched too.
Attachments
Change History
03/24/07 15:19:52: Modified by loopback
- attachment old_button.gif added.
03/24/07 15:20:17: Modified by loopback
- attachment new_button.gif added.
03/24/07 15:20:40: Modified by loopback
- attachment nd-close-button.patch added.
03/25/07 06:11:47: Modified by loopback
- cc set to luca.cavalli@gmail.com.
04/29/07 02:41:37: Modified by chipx86
05/06/07 06:19:18: Modified by loopback
Christian, sorry for the delay, but gmail put trac's notification mail into spam folder. Anyway, testing trunk right now. I agree with you about focus-on-click. The only difference is the close button a bit bigger than mine, since you don't set the size. BTW, other apps do this to keep the close button as small as possible (i.e. gedit in tabs) but here we have all the space we need, so I think it is fine also a bit bigger button.
PS: My last name is Cavalli, not Cavelli :D
05/06/07 06:33:16: Modified by loopback
- attachment newer_button.gif added.
Here is how the close button looks now.
06/13/07 02:08:50: Modified by chipx86
- status changed from new to closed.
- resolution set to fixed.
Okay, I think it's probably fine for it to be a bit bigger. As you said, we have the space. As the "X" looks clipped on some themes when focus on click and the forced smaller size, I think letting it be the natural size is fine for now. Going to close this out. Thanks!
I've committed part of this change to notification-daemon trunk. Can you test it and see if it works or if the rest of your change is needed?
I'm concerned about turning off focus on click, as that may have an impact on accessibility. I'm also not sure the button sizing is needed, as if we don't set the size, we should get a decent natural size.