Ticket #62 (defect)

Opened 2 years ago

Last modified 2 years ago

Broken makefiles

Status: reopened

Reported by: mzabaluev Assigned to: chipx86
Priority: normal Milestone:
Component: libgalago Version: 0.5.1
Severity: normal Keywords:
Cc: D-BUS Version:
Patch Included: 1 OS/Distro Version:

The makefiles in libgalago have some custom crack for mkinstalldirs location which breaks in certain configure settings. I'll attach a patch that fixes it.

Attachments

libgalago-0.5.1-mkinstalldirs.patch (0.9 kB) - added by mzabaluev on 06/05/06 06:42:29.
Patch for 0.5.1

Change History

06/05/06 06:39:03: Modified by chipx86

The mkinstalldirs change is made by setup-gettext. This breaks on some versions of gettext but not on others. Many versions of gettext (and I don't know when/if it was fixed) set mkinstalldirs incorrectly and would lead to errors.

06/05/06 06:42:29: Modified by mzabaluev

  • attachment libgalago-0.5.1-mkinstalldirs.patch added.

Patch for 0.5.1

06/05/06 06:45:03: Modified by mzabaluev

Granted the patch relies on a correct setting for the MAKEFILES substitution variable.

06/05/06 06:49:50: Modified by chipx86

Sorry, but that won't do. Those files are auto-generated, and any modifications we make will just be reverted next time autogen.sh is run.

06/05/06 12:54:51: Modified by mzabaluev

  • status changed from new to closed.
  • resolution set to worksforme.

OK, running glib-gettextize fixes it for me.

06/05/06 12:58:17: Modified by chipx86

  • status changed from closed to reopened.
  • resolution deleted.

No, this isn't fixed. We need to figure out why it's breaking for you.

What version of gettext is installed on your system? What about automake and autoconf?

If you get the SVN version of libgalago and run autogen.sh, does this still happen?

06/08/06 09:20:35: Modified by AlexExtreme

This issue also occurred for me when trying to update the libgalago package for Frugalware Linux to 0.5.1. I am using gettext 0.14.5, automake 1.9.6 and autoconf 2.59. I have just tried with the SVN version too, and the issue still occurs.

06/21/06 05:57:50: Modified by dholbach@ubuntu.com

The same happens for me on Ubuntu Dapper or Ubuntu Edgy. gettext 0.14.5 automake 1.9.6 autoconf 2.59

06/27/06 09:19:27: Modified by camplear

The patch works for me when building on Slackware 10.2 w/automake 1.95 gettext 0.14.3 autoconf 2.59. Here is the portion where it would normally fail (but succeded with patch):

Making install in po
make[1]: Entering directory `/usr/slackmatic/repos/clear/libgalago/work/src/libgalago-0.5.1/po'
.././mkinstalldirs /usr/slackmatic/repos/clear/libgalago/work/pkg/usr/share
mkdir -p -- /usr/slackmatic/repos/clear/libgalago/work/pkg/usr/share/locale/da/LC_MESSAGES
installing da.gmo as /usr/slackmatic/repos/clear/libgalago/work/pkg/usr/share/locale/da/LC_MESSAGES/libgalago.mo
mkdir -p -- /usr/slackmatic/repos/clear/libgalago/work/pkg/usr/share/locale/de/LC_MESSAGES
installing de.gmo as /usr/slackmatic/repos/clear/libgalago/work/pkg/usr/share/locale/de/LC_MESSAGES/libgalago.mo
mkdir -p -- /usr/slackmatic/repos/clear/libgalago/work/pkg/usr/share/locale/fr/LC_MESSAGES
installing fr.gmo as /usr/slackmatic/repos/clear/libgalago/work/pkg/usr/share/locale/fr/LC_MESSAGES/libgalago.mo
mkdir -p -- /usr/slackmatic/repos/clear/libgalago/work/pkg/usr/share/locale/pt_BR/LC_MESSAGES
installing pt_BR.gmo as /usr/slackmatic/repos/clear/libgalago/work/pkg/usr/share/locale/pt_BR/LC_MESSAGES/libgalago.mo
if test "libgalago" = "gettext"; then \
  .././mkinstalldirs /usr/slackmatic/repos/clear/libgalago/work/pkg/usr/share/gettext/po; \
  /usr/bin/ginstall -c -m 644 ./Makefile.in.in \
                  /usr/slackmatic/repos/clear/libgalago/work/pkg/usr/share/gettext/po/Makefile.in.in; \
else \
  : ; \
fi
make[1]: Leaving directory `/usr/slackmatic/repos/clear/libgalago/work/src/libgalago-0.5.1/po'

Here is the failed portion (patch not applied);

Making install in po
make[1]: Entering directory `/usr/slackmatic/repos/libgalago/work/src/libgalago-0.5.1/po'
/bin/sh `case ".././mkinstalldirs" in /*) echo ".././mkinstalldirs" ;; *) echo "../.././mkinstalldirs" ;; esac` /usr/slackmatic/repos/libgalago/work/pkg/usr/share
/bin/sh: ../.././mkinstalldirs: No such file or directory
make[1]: *** [install-data-yes] Error 127
make[1]: Leaving directory `/usr/slackmatic/repos/libgalago/work/src/libgalago-0.5.1/po'

07/29/06 16:26:18: Modified by chipx86

  • patch_included set to 1.

09/30/06 09:05:26: Modified by CuZnDragon

I am getting this also.

make[1]: Entering directory `/usr/src/libgalago-0.5.1/po' /bin/sh case ".././mkinstalldirs" in /*) echo ".././mkinstalldirs" ;; *) echo "../.././mkinstalldirs" ;; esac /usr/share /bin/sh: ../.././mkinstalldirs: No such file or directory make[1]: *** [install-data-yes] Error 127 make[1]: Leaving directory `/usr/src/libgalago-0.5.1/po' make: *** [install-recursive] Error 1

Installed packages glibc: 2.4 glib2: 2.12.3 libtool: 1.5.22 autoconf: 2.60 automake: 1.9.6 gettext: 0.15 dbus: 0.93 dbus-glib: 0.71