Ticket #63 (enhancement)
Opened 2 years ago
Last modified 2 years ago
add orientation support
Status: new
| Reported by: | chpe | Assigned to: | chipx86 |
|---|---|---|---|
| Priority: | normal | Milestone: | libnotify 1.0 |
| Component: | libnotify | Version: | 0.4.0 |
| Severity: | normal | Keywords: | |
| Cc: | D-BUS Version: | ||
| Patch Included: | 1 | OS/Distro Version: | |
As I said in ticket #60, my updated patch had the correct orientation support by using "horizontal"/"vertical" strings. Attached patch adds it back.
Attachments
Change History
06/05/06 05:15:27: Modified by chpe
- attachment libnotify.diff added.
06/05/06 06:37:22: Modified by chipx86
- type changed from defect to enhancement.
- version set to 0.4.0.
- component changed from libgalago to libnotify.
- milestone set to libnotify 1.0.
I guess I didn't inspect the code that carefully yesterday. Dealing with a pretty nasty head cold, and I'm making mistakes. I'll commit the patch, but one thing I'm still not sure about is providing the orientation in set_geometry_hints. I think that the orientation should instead be passed directly to set_hint_enum and not go through set_geometry_hints. In most cases, the daemon won't need to be told what the orientation is of the source, and really, it can figure out the proper arrow placement (top/bottom, left/right sides) based on screen size and x, y hints. As such, I'd like to hide this a bit more and not force developers to do the necessary calculations themselves or give them any kind of certainty that the hint will necessarily be supported.
07/29/06 16:27:53: Modified by chipx86
- patch_included set to 1.
add orientation